Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore minimum and maximum line-length enforcement in JSON schema #7877

Closed
charliermarsh opened this issue Oct 9, 2023 · 0 comments · Fixed by #7883
Closed

Restore minimum and maximum line-length enforcement in JSON schema #7877

charliermarsh opened this issue Oct 9, 2023 · 0 comments · Fixed by #7883
Labels
configuration Related to settings and configuration

Comments

@charliermarsh
Copy link
Member

According to the struct, the line-length property only supports values in (0, 320). We tried to enforce this range in the JSON schema, but ran into issues with validation and had to revert. See: #7875.

As an aside, the 320 limit also isn't enforced statically. I'm not sure where it came from, but (e.g.) Serde will allow you to instantiate a LineLength with a larger limit from your config.
@charliermarsh charliermarsh added the configuration Related to settings and configuration label Oct 9, 2023
@charliermarsh charliermarsh mentioned this issue Oct 9, 2023
Merged
@henryiii henryiii mentioned this issue Oct 10, 2023
Merged
charliermarsh pushed a commit that referenced this issue Oct 10, 2023
@henryiii
fix(schema): restore limit on line-length (#7883)
097b654 
## Summary

Restores functionality of #7875 but in the correct place. Closes #7877.

~~I couldn't figure out how to get cargo fmt to work, so hopefully
that's run in CI.~~ Nevermind, figured it out.

## Test Plan

Can see output of json.
konstin pushed a commit that referenced this issue Oct 11, 2023
@henryiii @konstin
fix(schema): restore limit on line-length (#7883)
674d5e3 
## Summary

Restores functionality of #7875 but in the correct place. Closes #7877.

~~I couldn't figure out how to get cargo fmt to work, so hopefully
that's run in CI.~~ Nevermind, figured it out.

## Test Plan

Can see output of json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
configuration Related to settings and configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(schema): restore limit on line-length henryiii/ruff
1 participant
@charliermarsh