Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): restore limit on line-length #7883

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 10, 2023

Summary

Restores functionality of #7875 but in the correct place. Closes #7877.

I couldn't figure out how to get cargo fmt to work, so hopefully that's run in CI. Nevermind, figured it out.

Test Plan

Can see output of json.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@charliermarsh
Copy link
Member

Ah excellent! Thank you @henryiii!

@charliermarsh charliermarsh merged commit 097b654 into astral-sh:main Oct 10, 2023
16 checks passed
@henryiii henryiii deleted the henryiii/fix/schemaminmax branch October 10, 2023 03:04
@zanieb
Copy link
Member

zanieb commented Oct 10, 2023

Thanks!!

konstin pushed a commit that referenced this pull request Oct 11, 2023
## Summary

Restores functionality of #7875 but in the correct place. Closes #7877.

~~I couldn't figure out how to get cargo fmt to work, so hopefully
that's run in CI.~~ Nevermind, figured it out.

## Test Plan

Can see output of json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore minimum and maximum line-length enforcement in JSON schema
3 participants