Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "nursery" rule group #7992

Closed
zanieb opened this issue Oct 16, 2023 · 2 comments · Fixed by #9680 · May be fixed by #10172
Closed

Remove the "nursery" rule group #7992

zanieb opened this issue Oct 16, 2023 · 2 comments · Fixed by #9680 · May be fixed by #10172
Assignees
@zanieb
Milestone
v0.3.0

Comments

@zanieb
Copy link
Member

zanieb commented Oct 16, 2023 •
edited

RuleGroup::Nursery is currently included for backwards compatibility but should be removed in Ruff v0.2.0

This change will include removing backwards compatible selection of nursery rules. All nursery rules should be moved to preview.
@zanieb zanieb added this to the v0.2.0 milestone Oct 16, 2023
@zanieb zanieb changed the title Remove RuleGroup::Nursery Remove the "nursery" rule group Oct 16, 2023
@zanieb
Copy link
Member Author

zanieb commented Oct 16, 2023

We may want to keep RuleSelector::Nursery in order to throw a nicer error message then remove it in v0.3.0 but I'm not sure how feasible that will be. If we keep it, we should hide it from the schema.

@charliermarsh charliermarsh mentioned this issue Jan 11, 2024
Closed
13 tasks
@zanieb zanieb self-assigned this Jan 29, 2024
This was referenced Jan 29, 2024
Merged
Merged
zanieb added a commit that referenced this issue Jan 29, 2024
@zanieb
Error if the NURSERY selector is used with preview (#9682)
4ccbacd 
Changes our warning for combined use of `--preview` and `--select
NURSERY` to a hard error.

This should go out _before_ #9680 where we will ban use of `NURSERY`
outside of preview as well (see #9683).

Part of #7992
@zanieb
Copy link
Member Author

zanieb commented Jan 29, 2024

In #9683 we make this error in most cases, but retain the selector for error messages.

In v0.3.0 we should remove the group entirely.

@zanieb zanieb modified the milestones: v0.2.0, v0.3.0 Jan 29, 2024
zanieb added a commit that referenced this issue Jan 30, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
0d543f0 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
zanieb added a commit that referenced this issue Jan 30, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
07c6a3e 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
@zanieb zanieb mentioned this issue Jan 30, 2024
Merged
zanieb added a commit that referenced this issue Feb 1, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
7c644d5 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
# Conflicts:
#	crates/ruff/tests/integration_test.rs
#	crates/ruff_workspace/src/configuration.rs
zanieb added a commit that referenced this issue Feb 1, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
a0f32df 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
# Conflicts:
#	crates/ruff/tests/integration_test.rs
#	crates/ruff_workspace/src/configuration.rs
@T-256 T-256 mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanieb zanieb

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Release v0.2.0 astral-sh/ruff
Drop deprecated nursery rule group T-256/ruff
1 participant
@zanieb