Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if the NURSERY selector is used with preview #9682

Merged
merged 2 commits into from Jan 29, 2024
Merged

Error if the NURSERY selector is used with preview #9682

merged 2 commits into from Jan 29, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 29, 2024 •
edited

Changes our warning for combined use of --preview and --select NURSERY to a hard error.

This should go out before #9680 where we will ban use of NURSERY outside of preview as well (see #9683).

Part of #7992

@zanieb zanieb added the preview Related to preview mode features label Jan 29, 2024
@zanieb zanieb mentioned this pull request Jan 29, 2024
Merged
@github-actions GitHub Actions
Copy link

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb zanieb merged commit 4ccbacd into main Jan 29, 2024
17 checks passed
@zanieb zanieb deleted the zb/nursery-err branch January 29, 2024 19:33
zanieb added a commit that referenced this pull request Jan 30, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
0d543f0 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
zanieb added a commit that referenced this pull request Jan 30, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
07c6a3e 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
7c644d5 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
# Conflicts:
#	crates/ruff/tests/integration_test.rs
#	crates/ruff_workspace/src/configuration.rs
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Error if nursery rules are selected without preview (#9683)
a0f32df 
Extends #9682 to error if the nursery selector is used or nursery rules
are selected without preview.

Part of #7992 — we will remove this in 0.3.0 instead so we can provide
nice errors in 0.2.0.
# Conflicts:
#	crates/ruff/tests/integration_test.rs
#	crates/ruff_workspace/src/configuration.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zanieb @charliermarsh