Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refurb] Fix misbehavior of operator.itemgetter when getter param is a tuple #11774

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

Embers-of-the-Fire
Copy link
Contributor

Summary

This should fix #11714.

Test Plan

Tested with the example code mentioned in the issue.

Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #11774 will not alter performance

Comparing Embers-of-the-Fire:fix-issue-#11714 (5fba1c6) with Embers-of-the-Fire:fix-issue-#11714 (4bd264e)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jun 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-assigned this Jun 7, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Jun 7, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh changed the title [Bug fix] Fix misbehaviour of operator.itemgetter when the getter param is a tuple [refurb] Fix misbehavior of operator.itemgetter when the getter param is a tuple Jun 7, 2024
@charliermarsh charliermarsh changed the title [refurb] Fix misbehavior of operator.itemgetter when the getter param is a tuple [refurb] Fix misbehavior of operator.itemgetter when getter param is a tuple Jun 7, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) June 7, 2024 03:07
@charliermarsh charliermarsh merged commit ea27445 into astral-sh:main Jun 7, 2024
19 checks passed
@Embers-of-the-Fire Embers-of-the-Fire deleted the fix-issue-#11714 branch June 7, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FURB118, lambda x: x[I, ii] should be itemgetter((I, ii)), instead of itemgetter(I, ii)
2 participants