Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff server: Support the usage of tildes and environment variables in logFile #11945

Merged
merged 5 commits into from
Jun 20, 2024
Merged

ruff server: Support the usage of tildes and environment variables in logFile #11945

merged 5 commits into from
Jun 20, 2024

Conversation

snowsignal
Copy link
Contributor

Summary

Fixes #11911.

shellexpand is now used on logFile to expand the file path, allowing the usage of ~ and environment variables.

Test Plan

  1. Set logFile in either Neovim or Helix to a file path that needs expansion, like ~/.config/helix/ruff_logs.txt.
  2. Ensure that RUFF_TRACE is set to messages or verbose
  3. Open a Python file in Neovim/Helix
  4. Confirm that a file at the path specified was created, with the expected logs.

@snowsignal snowsignal added the server Related to the LSP server label Jun 20, 2024
@snowsignal snowsignal added this to the Ruff Server: Stable milestone Jun 20, 2024
@snowsignal snowsignal changed the title ruff server: The logFile setting now supports expanded paths ruff server: Support the usage of tildes and environment variables in logFile Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dhruvmanila
dhruvmanila approved these changes Jun 20, 2024
View reviewed changes
crates/ruff_server/docs/setup/NEOVIM.md Outdated Show resolved Hide resolved
crates/ruff_server/src/trace.rs Outdated Show resolved Hide resolved
@snowsignal snowsignal enabled auto-merge (squash) June 20, 2024 04:16
MichaReiser
MichaReiser approved these changes Jun 20, 2024
View reviewed changes
crates/ruff_server/src/session/settings.rs Show resolved Hide resolved
crates/ruff_server/src/trace.rs Outdated Show resolved Hide resolved
@snowsignal snowsignal merged commit c8ff89c into main Jun 20, 2024
18 checks passed
@snowsignal snowsignal deleted the jane/server/config/logfile-shellexpand branch June 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
server Related to the LSP server
Projects
None yet
Milestone
Ruff Server: Stable
Development

Successfully merging this pull request may close these issues.

The logFile language server setting should support shell expansion
3 participants
@snowsignal @MichaReiser @dhruvmanila