Simplify unused snapshot check #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May need to install insta as part of the job. |
harupy
commented
Jan 1, 2023
harupy
force-pushed
the
improve-unused-snapshot-check
branch
from
28e4a46
to
df89ee9
Compare
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Jan 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.205` -> `^0.0.206` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.206`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.206) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.205...v0.0.206) #### What's Changed - PyUpgrade: Turn errors into OSError by [@​colin99d](https://togithub.com/colin99d) in [astral-sh/ruff#1434 - Add dark mode variant for benchmark image by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1519 - Ignore property assignments in RET504 by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1520 - Avoid some false positives for ends-in-period checks by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1521 - Pyupgrade: `import mock` to `from unittest import mock` by [@​colin99d](https://togithub.com/colin99d) in [astral-sh/ruff#1488 - Fix `Name` node range in `NamedExpr` node by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1526 - Simplify unused snapshot check by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1525 - Do not Change Quotation Style for `SIM118` Autofix by [@​saadmk11](https://togithub.com/saadmk11) in [astral-sh/ruff#1529 - Add `visit_format_spec` to avoid false positives for F541 in f-string format specifier by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1528 - Rewrite mock.mock attribute accesses by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1533 **Full Changelog**: astral-sh/ruff@v0.0.205...v0.0.206 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the unused snapshot check by applying @max-sixty's suggestion here.