Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PEP 604 rewrites for runtime annotations #1563

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Resolves #1560.

@charliermarsh charliermarsh merged commit 9ffd207 into main Jan 2, 2023
@charliermarsh charliermarsh deleted the charlie/up branch January 2, 2023 21:33
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 3, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.207` ->
`^0.0.208` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.208/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.208/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.208/compatibility-slim/0.0.207)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.208/confidence-slim/0.0.207)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.208`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.208)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.207...v0.0.208)

#### What's Changed

- Adds a codespell linter by
[@&#8203;colin99d](https://togithub.com/colin99d) in
[astral-sh/ruff#1553
- Avoid merging import from statements with inline comments by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1562
- Avoid PEP 604 rewrites for runtime annotations by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1563
- Implement `flake8-pytest-style` by
[@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) in
[astral-sh/ruff#1506
- Always check directly-passed-in files by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1564
- Remove common-path dependency by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1565
- Rename checks.rs to registry.rs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1566
- Remove extend- from docstring configuration examples by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1571
- Avoid invalid trailing comma fixes for mock rewrites by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1570
- Automatically set baseline D codes based on convention by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1574
- Remove need for vendored format/cformat code by
[@&#8203;olliemath](https://togithub.com/olliemath) in
[astral-sh/ruff#1573
- Warn user when D203 and D211 are enabled by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1576
- Add `flake8-pie` plugin with `prefer_list_builtin` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1578
- Add scripts to generate plugin and check boilerplate by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1579
- Implement unnecessary-pass-statement by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1580
- Implement dupe-class-field-definitions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1581
- Implement autofix for F541 by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#1577
- Add a link to GitHub from the playground by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1583
- Mark `FStringMissingPlaceholders` as fixable by
[@&#8203;harupy](https://togithub.com/harupy) in
[astral-sh/ruff#1582
- Swap accent color for playground by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1584
- Prefer GitHub icon on mobile by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1585
- Implement and-false and or-true rules by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#1586

**Full Changelog**:
astral-sh/ruff@v0.0.207...v0.0.208

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
charliermarsh added a commit that referenced this pull request Feb 1, 2023
I moved the `self.in_annotation` guard out of the version check in #1563. But, I think that was a mistake. It was done to resolve #1560, but the fix in that case _should've_ been to set a different Python version.

Closes #2447.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly a false positive for UP007
1 participant