Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-pie PIE804: no-unnecessary-dict-kwargs #1884

Merged
merged 10 commits into from
Jan 23, 2023

Conversation

sbdchd
Copy link
Contributor

@sbdchd sbdchd commented Jan 15, 2023

Warn about things like foo(**{"bar": True}) which is equivalent to foo(bar=True)

rel: #1879
rel: #1543

charliermarsh pushed a commit that referenced this pull request Jan 22, 2023
This PR upgrades RustPython to fix the type of `Dict.keys` to `Vec<Option<Expr>>` (see RustPython/RustPython#4449 for why this change was needed) and unblock #1884.
@charliermarsh
Copy link
Member

This should be unblocked by the RustPython AST improvements that we just merged in.

@sbdchd sbdchd changed the title wip: Add flake8-pie PIE804: no-unnecessary-dict-kwargs Add flake8-pie PIE804: no-unnecessary-dict-kwargs Jan 22, 2023
@sbdchd sbdchd marked this pull request as ready for review January 23, 2023 00:04
@charliermarsh charliermarsh merged commit 4ca328f into astral-sh:main Jan 23, 2023
bruxisma pushed a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 24, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.230` ->
`^0.0.231` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.231/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.231/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.231/compatibility-slim/0.0.230)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.231/confidence-slim/0.0.230)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.231`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.231)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.230...v0.0.231)

#### What's Changed

- fix: issue D401 only for non-test/property functions and methods by
[@&#8203;scop](https://togithub.com/scop) in
[astral-sh/ruff#2071
- feat: flake8-use-pathlib PTH100-124 by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2090
- refactor: remove redundant enum by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2091
- feat: Implement TRY201 by
[@&#8203;alonme](https://togithub.com/alonme) in
[astral-sh/ruff#2073
- Avoid nested-if violations when outer-if has else clause by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2095
- Add flake8-pie PIE804: no-unnecessary-dict-kwargs by
[@&#8203;sbdchd](https://togithub.com/sbdchd) in
[astral-sh/ruff#1884
- Add flake8-pie PIE800: no-unnecessary-spread by
[@&#8203;sbdchd](https://togithub.com/sbdchd) in
[astral-sh/ruff#1881
- Remove some usages of default format for expressions by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[astral-sh/ruff#2100
- docs(readme): add pypa cibuildwheel by
[@&#8203;sbrugman](https://togithub.com/sbrugman) in
[astral-sh/ruff#2107
- refactor: Get rid of `build.rs` and other refactors by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[astral-sh/ruff#2101
- Fix outdated description of ruff's support of isort settings by
[@&#8203;thomkeh](https://togithub.com/thomkeh) in
[astral-sh/ruff#2106
- \[`flake8-bandit`] Added Rule `S612` (Use of insecure
`logging.config.listen`) by
[@&#8203;saadmk11](https://togithub.com/saadmk11) in
[astral-sh/ruff#2108

#### New Contributors

- [@&#8203;sbdchd](https://togithub.com/sbdchd) made their first
contribution in
[astral-sh/ruff#1884

**Full Changelog**:
astral-sh/ruff@v0.0.230...v0.0.231

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDkuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOS4xIn0=-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants