Add a dedicated token indexer for continuations and comments #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/indexer
branch
from
f5b2eb6
to
f263e40
Compare
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Jan 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.222` -> `^0.0.223` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.223`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.223) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.222...v0.0.223) #### What's Changed - Turn define_rule_mapping! into a procedural macro by [@​not-my-profile](https://togithub.com/not-my-profile) in [astral-sh/ruff#1885 - Convert confusable violations to named fields by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1887 - Add a dedicated token indexer for continuations and comments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1886 - Remove some Clippy allows by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1888 - Update add plugin/rule scripts by [@​messense](https://togithub.com/messense) in [astral-sh/ruff#1889 - Improve magic value message wording by [@​TomFryers](https://togithub.com/TomFryers) in [astral-sh/ruff#1892 - Use more precise error ranges for RET505~508 by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1895 - Implement flake8-commas by [@​bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#1872 - refactor: Split CliSettings from Settings by [@​not-my-profile](https://togithub.com/not-my-profile) in [astral-sh/ruff#1891 - Skip noqa checker if no diagnostics are found by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1898 - Don't require docstrings for setters and deleters by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1899 - Buffer diagnostic writes to `stdout` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1900 - Lock `stdout` once when printing diagnostics by [@​messense](https://togithub.com/messense) in [astral-sh/ruff#1901 - Avoid triggering SIM117 for async with statements by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1903 #### New Contributors - [@​TomFryers](https://togithub.com/TomFryers) made their first contribution in [astral-sh/ruff#1892 **Full Changelog**: astral-sh/ruff@v0.0.222...v0.0.223 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDIuNyIsInVwZGF0ZWRJblZlciI6IjM0LjEwMi43In0=--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation is that we can now robustly detect
\continuations due to the addition ofTok::NonLogicalNewline. This PR generalizes the approach we took to comments (track all lines that contain any comments), and applies it to continuations too.