Move compare to helpers file #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From discussion on astral-sh#2123 I didn't originally have a helpers file so I put the function in both places but now that a helpers file exists it seems logical for it to be there.
ericroberts
force-pushed
the
compare-helper
branch
from
a336072
to
1c1c6a8
Compare
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Jan 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.231` -> `^0.0.235` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.235`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.235) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.234...v0.0.235) #### Summary Follow-up release to `v0.0.234` to fix two non-fatal issues related to CLI output. (No new rules or functionality.) #### What's Changed - Avoid duplicate CI runs triggered by pushes to pull requests by [@​andersk](https://togithub.com/andersk) in [astral-sh/ruff#2178 - Restore single-file license by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2180 - Windows compatibility by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#2033 - Remove stray parenthesis from fixed errors message by [@​andersk](https://togithub.com/andersk) in [astral-sh/ruff#2181 - Fix conflicting error message warning by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2182 **Full Changelog**: astral-sh/ruff@v0.0.234...v0.0.235 ### [`v0.0.234`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.234) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.233...v0.0.234) #### What's Changed - Move is_overlong to helpers by [@​ericroberts](https://togithub.com/ericroberts) in [astral-sh/ruff#2137 - Update .pre-commit-config.yml by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#2139 - Avoid generating dirty call paths by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2144 - Implement runtime-import-in-type-checking-block (TYP004) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2146 - Implement typing-only import detection (TYP001, TYP002, TYP003) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2147 - Add `#![warn(clippy::pedantic)]` to lib.rs and main.rs files by [@​not-my-profile](https://togithub.com/not-my-profile) in [astral-sh/ruff#2148 - Treat Python 3.7 as minimum supported version by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2159 - Avoid flagging unused loop variable (B007) with locals() by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2161 - Avoid prefer-type-error (TRY004) with intermediary control flow by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2162 - Add an FAQ on autofix by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2163 - Avoid re-resolving settings for repeated paths by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2165 - Suggest input format in error case by [@​spaceone](https://togithub.com/spaceone) in [astral-sh/ruff#2167 - Re-add error wrapper in main.rs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2168 - fix: avoid flagging unused loop variable (B007) with globals(), vars() or eval() by [@​spaceone](https://togithub.com/spaceone) in [astral-sh/ruff#2166 - Fix singular and plural for "error(s)" by [@​hugovk](https://togithub.com/hugovk) in [astral-sh/ruff#2157 - Add Babel to readme by [@​akx](https://togithub.com/akx) in [astral-sh/ruff#2170 - Add flake8-builtins options to README by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2173 - Avoid reraise-no-cause for explicit reraises by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2174 - Rename TYP rules to TYC by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2175 - Actually, rename TYP rules to TCH by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2176 **Full Changelog**: astral-sh/ruff@v0.0.233...v0.0.234 ### [`v0.0.233`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.233) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.231...v0.0.233) This is a rerun of `v0.0.232` (unreleased) to address build failures on Windows. #### What's Changed - Move compare to helpers file by [@​ericroberts](https://togithub.com/ericroberts) in [astral-sh/ruff#2131 - Enable executable checks on Windows by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2133 **Full Changelog**: astral-sh/ruff@v0.0.232...v0.0.233 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion on #2123
I didn't originally have a helpers file so I put the function in both places but now that a helpers file exists it seems logical for it to be there.