Ignore magic comparisons to bytes by default #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Jan 31, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.237` -> `^0.0.238` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.238`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.238) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.237...v0.0.238) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed #####⚠️ Breaking Changes⚠️ ##### `select`, `extend-select`, `ignore`, and `extend-ignore` have new semantics ([#​2312](https://togithub.com/charliermarsh/ruff/pull/2312)) Previously, the interplay between `select` and its related options could lead to unexpected behavior. For example, `ruff --select E501 --ignore ALL` and `ruff --select E501 --extend-ignore ALL` behaved differently. (See [#​2312](https://togithub.com/charliermarsh/ruff/pull/2312) for more examples.) The new semantics are such that Ruff uses the "highest-priority" `select` as the basis for the rule set, and then applies any `extend-select`, `ignore`, and `extend-ignore` adjustments. CLI options are given higher priority than `pyproject.toml` options, and the current `pyproject.toml` file is given higher priority than any inherited `pyproject.toml` files. As an example: `ruff --select F401` will select rule `F401`, and ignore any of the modifiers from the `pyproject.toml`, as the "highest-priorty" select kicks off the resolution chain. This change is largely backwards compatible -- most users should experience no change in behavior. For more, see [BREAKING_CHANGES.md](https://togithub.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md#select-extend-select-ignore-and-extend-ignore-have-new-semantics-2312). ##### `remove-six-compat` (`UP016`) has been removed ([#​2332](https://togithub.com/charliermarsh/ruff/pull/2332)) The `remove-six-compat` rule has been removed. This rule was only useful for one-time Python 2-to-3 upgrades. ##### Rules - Implement Pylint's `too-many-arguments` rule (`PLR0913`) by [@​akhildevelops](https://togithub.com/akhildevelops) in [astral-sh/ruff#2308 - Extend conventional imports defaults to include TensorFlow et al by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#2353 ##### Settings - feat: add ruff --statistics by [@​spaceone](https://togithub.com/spaceone) in [astral-sh/ruff#2284 - Ignore magic comparisons to bytes by default by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2365 - Implement `ruff linter` subcommand by [@​not-my-profile](https://togithub.com/not-my-profile) in [astral-sh/ruff#2294 - Improve rule config resolution by [@​not-my-profile](https://togithub.com/not-my-profile) in [astral-sh/ruff#2312 ##### Bug Fixes - Refine criteria for `exc_info` logger rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2364 - Respect per-file-ignores when checking noqa by [@​sciyoshi](https://togithub.com/sciyoshi) in [astral-sh/ruff#2309 - Place star before other member imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2320 - Allow list comprehensions for **all** assignment by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2326 - \[`TRY201`] don't check raise statements in nested exception handlers by [@​sciyoshi](https://togithub.com/sciyoshi) in [astral-sh/ruff#2337 - include tomllib in standard lib by [@​sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#2345 - Avoid removing trailing comments when autofixing by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2352 - \[`I001`] fix isort for files with tab-based indentation by [@​sciyoshi](https://togithub.com/sciyoshi) in [astral-sh/ruff#2361 - Disable incompatible rules rather than merely warning by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#2369 #### New Contributors - [@​chirag127](https://togithub.com/chirag127) made their first contribution in [astral-sh/ruff#2307 - [@​akhildevelops](https://togithub.com/akhildevelops) made their first contribution in [astral-sh/ruff#2308 **Full Changelog**: astral-sh/ruff@v0.0.237...v0.0.238 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTYuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNi4xIn0=--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2357.