[flake8-pytest-style] autofix for composite-assertion (PT018)

[sbrugman]

Autofix for composite assertion/PT018

Made some choices to keep it simple, see the test file for details.

[spaceone]

C417 doesn't detect all cases anymore.
It fixes:

-        assert all(map(lambda v: isinstance(v, dict), iterator))
+        assert all((isinstance(v, dict) for v in iterator))

better would be:

-        assert all(map(lambda v: isinstance(v, dict), iterator))
+        assert all(isinstance(v, dict) for v in iterator)

[spaceone]

btw - replacing filter() in the same manner would also be helpful.

[spaceone]

with the MR the following is not detected anymore as C417: bitstring = ''.join(map(lambda x: x in logontimes and '1' or '0', range(168)))

[sbrugman]

Thanks, will look at them (in #2693, this PR was intended for PT018)

[spaceone]

I found out why I have so many differences in the detection of that code:

Prior each finding emitted two violations:

C417 Unnecessary `map` usage (rewrite using a `list` comprehension)
C417 Unnecessary `map` usage (rewrite using a generator expression)

Now only one is detected:

C417 Unnecessary `map` usage (rewrite using a `list` comprehension)

→ I think this is ok.

[sbrugman]

Alternative: repeat message for each subcondition

[charliermarsh]

I think this is the right call (not to fix these cases).

[sbrugman]

Needs to be excluded after refactor