Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase expected size of FormatElement #3049

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Increase expected size of FormatElement #3049

merged 1 commit into from
Feb 20, 2023

Conversation

charliermarsh
Copy link
Member

It looks like this is now 32usize due to StaticTextSlice. We should revisit this.

@charliermarsh
Copy link
Member Author

\cc @MichaReiser

@charliermarsh charliermarsh merged commit d21dd99 into main Feb 20, 2023
@charliermarsh charliermarsh deleted the charlie/target-size branch February 20, 2023 17:47
@MichaReiser
Copy link
Member

This is unfortunate, but I don't see another way of modeling the TextSlice without implementing Rc manually (that does not have a weak reference counter). The good news is that shrinking the FormatElement size from 32 to 24 bytes wasn't as big a performance improvement as bringing it down to 32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @MichaReiser