Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructure Snapshot #4358

Merged
merged 1 commit into from
May 10, 2023
Merged

Destructure Snapshot #4358

merged 1 commit into from
May 10, 2023

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh enabled auto-merge (squash) May 10, 2023 19:32
@charliermarsh charliermarsh changed the title Remove Copy and destructure Snapshot Destructure Snapshot May 10, 2023
@charliermarsh charliermarsh merged commit f4f8830 into main May 10, 2023
@charliermarsh charliermarsh deleted the charlie/snapshot branch May 10, 2023 19:46
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     13.7±0.07ms     3.0 MB/sec    1.04     14.3±0.07ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.00ms     5.0 MB/sec    1.02      3.4±0.00ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    412.2±0.74µs     7.2 MB/sec    1.01    417.6±0.83µs     7.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.8±0.01ms     4.4 MB/sec    1.03      5.9±0.02ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      6.8±0.01ms     6.0 MB/sec    1.09      7.4±0.04ms     5.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1455.5±1.96µs    11.4 MB/sec    1.06   1541.7±1.53µs    10.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    160.8±0.28µs    18.4 MB/sec    1.04    167.6±0.29µs    17.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.01ms     8.3 MB/sec    1.06      3.3±0.01ms     7.8 MB/sec
parser/large/dataset.py                    1.01      5.4±0.00ms     7.6 MB/sec    1.00      5.3±0.01ms     7.6 MB/sec
parser/numpy/ctypeslib.py                  1.00   1045.0±0.57µs    15.9 MB/sec    1.00   1046.0±0.81µs    15.9 MB/sec
parser/numpy/globals.py                    1.00    105.9±0.25µs    27.9 MB/sec    1.00    105.7±0.15µs    27.9 MB/sec
parser/pydantic/types.py                   1.00      2.3±0.00ms    11.2 MB/sec    1.00      2.3±0.00ms    11.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.2±0.22ms     2.5 MB/sec    1.00     16.2±0.21ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.1±0.06ms     4.0 MB/sec    1.00      4.1±0.06ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    489.1±6.86µs     6.0 MB/sec    1.01    496.1±7.18µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.9±0.06ms     3.7 MB/sec    1.00      6.8±0.07ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      8.2±0.11ms     5.0 MB/sec    1.00      8.2±0.08ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1726.2±24.20µs     9.6 MB/sec    1.00  1731.4±15.89µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    191.6±3.75µs    15.4 MB/sec    1.02    195.9±5.83µs    15.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.06ms     6.9 MB/sec    1.00      3.7±0.06ms     6.9 MB/sec
parser/large/dataset.py                    1.00      6.7±0.05ms     6.1 MB/sec    1.02      6.8±0.05ms     6.0 MB/sec
parser/numpy/ctypeslib.py                  1.00  1266.3±11.58µs    13.1 MB/sec    1.02  1292.1±19.72µs    12.9 MB/sec
parser/numpy/globals.py                    1.00    129.8±2.03µs    22.7 MB/sec    1.02    132.0±5.65µs    22.3 MB/sec
parser/pydantic/types.py                   1.00      2.8±0.04ms     9.0 MB/sec    1.02      2.9±0.04ms     8.8 MB/sec

MichaReiser pushed a commit that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant