[`flake8-pyi`] Implement PYI002, PYI003, PYI004, PYI005 #5457

density · 2023-07-01T19:55:07Z

Summary

Implements flake8-pyi checks 002, 003, 004, 005. The logic is a bit complex, as you can see in the original code.

Test Plan

Updated snapshot tests. Ran flake8 to double check lints, and ran ruff with all PYI lints enabled to check for incorrect overlapping lint errors.

density · 2023-07-01T20:00:44Z

Tests are failing with Rule index out of bounds. Increase the size of the bitset array., which I assume means we've added enough rules (yay) that it's time to increase the size? I defer to the maintainers on what the best course of action is.

charliermarsh · 2023-07-01T21:03:43Z

Do you mind bumping const RULESET_SIZE: usize = 10; to const RULESET_SIZE: usize = 11; in registry/rule_set.rs as part of this PR?

density · 2023-07-01T21:29:39Z

Done @charliermarsh

github-actions · 2023-07-01T21:38:35Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                    pr
-----                                      ----                                    --
formatter/large/dataset.py                 1.01     10.3±0.32ms     4.0 MB/sec     1.00     10.2±0.47ms     4.0 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.09ms     7.5 MB/sec     1.00      2.2±0.09ms     7.5 MB/sec
formatter/numpy/globals.py                 1.00   254.8±14.29µs    11.6 MB/sec     1.10   281.6±44.16µs    10.5 MB/sec
formatter/pydantic/types.py                1.01      4.9±0.16ms     5.2 MB/sec     1.00      4.8±0.19ms     5.3 MB/sec
linter/all-rules/large/dataset.py          1.02     18.5±0.68ms     2.2 MB/sec     1.00     18.1±0.66ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.4±0.16ms     3.8 MB/sec     1.01      4.4±0.22ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.00   564.8±24.07µs     5.2 MB/sec     1.00   565.8±22.85µs     5.2 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.9±0.34ms     3.2 MB/sec     1.00      7.7±0.26ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.02      8.9±0.38ms     4.5 MB/sec     1.00      8.8±0.26ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.07  1963.9±128.99µs     8.5 MB/sec    1.00  1838.4±73.07µs     9.1 MB/sec
linter/default-rules/numpy/globals.py      1.13   251.6±21.25µs    11.7 MB/sec     1.00   222.5±13.02µs    13.3 MB/sec
linter/default-rules/pydantic/types.py     1.05      4.1±0.17ms     6.2 MB/sec     1.00      3.9±0.14ms     6.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.05     12.6±0.32ms     3.2 MB/sec    1.00     12.0±1.05ms     3.4 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.7±0.10ms     6.3 MB/sec    1.02      2.7±0.28ms     6.1 MB/sec
formatter/numpy/globals.py                 1.01    285.8±8.87µs    10.3 MB/sec    1.00   281.7±33.92µs    10.5 MB/sec
formatter/pydantic/types.py                1.03      5.8±0.22ms     4.4 MB/sec    1.00      5.7±0.49ms     4.5 MB/sec
linter/all-rules/large/dataset.py          1.02     20.2±0.47ms     2.0 MB/sec    1.00     19.8±0.29ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.03      5.3±0.18ms     3.1 MB/sec    1.00      5.2±0.14ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.01   630.0±27.20µs     4.7 MB/sec    1.00   626.3±25.79µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.03      9.1±0.29ms     2.8 MB/sec    1.00      8.8±0.23ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.01     10.2±0.25ms     4.0 MB/sec    1.00     10.0±0.21ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01      2.2±0.07ms     7.7 MB/sec    1.00      2.2±0.07ms     7.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    248.5±8.16µs    11.9 MB/sec    1.03   255.7±34.82µs    11.5 MB/sec
linter/default-rules/pydantic/types.py     1.02      4.6±0.15ms     5.6 MB/sec    1.00      4.5±0.13ms     5.7 MB/sec

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `^0.0.275` -> `^0.0.276` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/compatibility-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/confidence-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.276`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.275...v0.0.276)  See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://togithub.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@density](https://togithub.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#5402](https://togithub.com/astral-sh/ruff/issues/5402)) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@intgr](https://togithub.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@mayrholu](https://togithub.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@hauntsaninja](https://togithub.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@mayrholu](https://togithub.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@hauntsaninja](https://togithub.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@ethunk](https://togithub.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@LouisDISPA](https://togithub.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `0.0.275` -> `0.0.276` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/compatibility-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.276/confidence-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.276`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.275...v0.0.276)  See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://togithub.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@density](https://togithub.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#5402](https://togithub.com/astral-sh/ruff/issues/5402)) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@intgr](https://togithub.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@mayrholu](https://togithub.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@hauntsaninja](https://togithub.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@mayrholu](https://togithub.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@hauntsaninja](https://togithub.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@ethunk](https://togithub.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@LouisDISPA](https://togithub.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.275` -> `==0.0.277` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.277/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.277/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.277/compatibility-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.277/confidence-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.277`](https://togithub.com/astral-sh/ruff/compare/v0.0.276...v0.0.277) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.276...v0.0.277) ### [`v0.0.276`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.275...v0.0.276)  See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://togithub.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@density](https://togithub.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#5402](https://togithub.com/astral-sh/ruff/issues/5402)) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@intgr](https://togithub.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@mayrholu](https://togithub.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@hauntsaninja](https://togithub.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@mayrholu](https://togithub.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@hauntsaninja](https://togithub.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@ethunk](https://togithub.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@LouisDISPA](https://togithub.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.275` -> `==0.0.278` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.278/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.278/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.278/compatibility-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.278/confidence-slim/0.0.275)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.278`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.278) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.277...v0.0.278)  See the [release blog post](https://astral.sh/blog/ruff-v0.0.278) for more, including detailed descriptions of any newly added rules. #### What's Changed ##### Rules - \[`pylint`] Implement `typevar-bivariance` (`PLC0131`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5517 - \[`flake8-pyi`] Implement `unnecessary-literal-union` (`PYI030`) by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#5570 - \[`pylint`] Implement `type-name-incorrect-variance` (`PLC0105`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5651 - \[`ruff`] Implement `unnecessary-list-allocation-for-first-element` (`RUF015`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#5549 - \[`flake8-bugbear`] Implement `re-sub-positional-args` (`B034`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5669 - \[`ruff`] Implement `invalid-index-type` (`RUF016`) by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#5602 ##### Settings - \[`isort`] Add `--case-sensitive` flag by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5539 - \[`isort`] Support globbing in `isort` options by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5473 ##### Bug Fixes - Support autofix for some multiline `str.format` calls by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5638 - Avoid triggering `unnecessary-map` (`C417`) for late-bound lambdas by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5520 - Avoid triggering DTZ001-006 when using `.astimezone()` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5524 - Enable attribute lookups via semantic model by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5536 - Avoid syntax errors when rewriting str(dict) in f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5538 - Differentiate between runtime and typing-time annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5575 - Only run pyproject.toml lint rules when enabled by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5578 - Refactor isort directive skips to use iterators by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5623 - Allow descriptor instantiations in dataclass fields by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5537 - Refactor `noqa` directive parsing away from regex-based implementation by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5554 - Emit warnings for invalid `# noqa` directives by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5571 - Support individual codes on `# flake8: noqa` directives by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5618 - Add `tkinter` import convention by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5626 - Avoid `PERF401` if conditional depends on list var by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5603 - Fix typo in complex-if-statement-in-stub message by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5635 - Make TRY301 trigger only if a `raise` throws a caught exception by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#5455 - Skip flake8-future-annotations checks in stub files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5652 - Always allow PEP 585 and PEP 604 rewrites in stub files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5653 - Add support for `Union` declarations without `|` to PYI016 by [@zanieb](https://togithub.com/zanieb) in [astral-sh/ruff#5598 - Ignore `_name_` and `_value_` accesses in `flake8-self` rules by [@monosans](https://togithub.com/monosans) in [astral-sh/ruff#5663 - Refactor `repeated_keys()` to use `ComparableExpr` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5696 #### New Contributors - [@karosis88](https://togithub.com/karosis88) made their first contribution in [astral-sh/ruff#5560 - [@petermattia](https://togithub.com/petermattia) made their first contribution in [astral-sh/ruff#5579 - [@DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) made their first contribution in [astral-sh/ruff#5607 **Full Changelog**: astral-sh/ruff@v0.0.277...v0.0.278 ### [`v0.0.277`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.277) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.276...v0.0.277)  #### What's Changed ##### Breaking Changes - Add .ipynb_checkpoints, .pyenv, .pytest_cache, and .vscode to default excludes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5513 ##### Rules - \[`pylint`] Implement Pylint `typevar-name-mismatch` (`C0132`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5501 ##### Settings - Add `ruff rule --all` subcommand (with JSON output) by [@akx](https://togithub.com/akx) in [astral-sh/ruff#5059 ##### Bug Fixes - Fix eval detection for suspicious-eval-usage by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5506 - Avoid PERF rules for iteration-dependent assignments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5508 - Avoid returning first-match for rule prefixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5511 **Full Changelog**: astral-sh/ruff@v0.0.276...v0.0.277 ### [`v0.0.276`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.275...v0.0.276)  See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://togithub.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@density](https://togithub.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#5402](https://togithub.com/astral-sh/ruff/issues/5402)) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@intgr](https://togithub.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@mayrholu](https://togithub.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@hauntsaninja](https://togithub.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@mayrholu](https://togithub.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@hauntsaninja](https://togithub.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@ethunk](https://togithub.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@LouisDISPA](https://togithub.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[flake8-pyi] Implement PYI002, PYI003, PYI004, PYI005

86cf304

density marked this pull request as ready for review July 1, 2023 20:00

bump RULESET_SIZE

d703a95

charliermarsh added 2 commits July 2, 2023 22:04

Merge branch 'main' into PYI-comparisons

10af649

Tweak docs

dcdf77d

charliermarsh added the rule Implementing or modifying a lint rule label Jul 3, 2023

Re-generate schema

76f18ff

charliermarsh mentioned this pull request Jul 3, 2023

Add PYI002 Rule #5453

Closed

charliermarsh merged commit 0bff4ed into astral-sh:main Jul 3, 2023
15 checks passed

density deleted the PYI-comparisons branch July 3, 2023 13:07

chenrui333 mentioned this pull request Jul 3, 2023

ruff 0.0.276 Homebrew/homebrew-core#135688

Merged

renovate bot mentioned this pull request Aug 18, 2023

chore(pre-commit): update ruff to v0.1.6 scop/bash-completion#1009

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`flake8-pyi`] Implement PYI002, PYI003, PYI004, PYI005 #5457

[`flake8-pyi`] Implement PYI002, PYI003, PYI004, PYI005 #5457

density commented Jul 1, 2023 •

edited

Loading

density commented Jul 1, 2023

charliermarsh commented Jul 1, 2023

density commented Jul 1, 2023

github-actions bot commented Jul 1, 2023 •

edited

Loading

[flake8-pyi] Implement PYI002, PYI003, PYI004, PYI005 #5457

[flake8-pyi] Implement PYI002, PYI003, PYI004, PYI005 #5457

Conversation

density commented Jul 1, 2023 • edited Loading

Summary

Test Plan

density commented Jul 1, 2023

charliermarsh commented Jul 1, 2023

density commented Jul 1, 2023

github-actions bot commented Jul 1, 2023 • edited Loading

PR Check Results

Ecosystem

Benchmark

Linux

Windows

[`flake8-pyi`] Implement PYI002, PYI003, PYI004, PYI005 #5457

[`flake8-pyi`] Implement PYI002, PYI003, PYI004, PYI005 #5457

density commented Jul 1, 2023 •

edited

Loading

github-actions bot commented Jul 1, 2023 •

edited

Loading