Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid extra named .none #1428

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Ignore invalid extra named .none #1428

merged 1 commit into from
Feb 16, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Some packages erroneously include an extra named .none. It turns out that certain versions of flit included this by accident: pypa/flit#228.

This PR adds leniency for that specific extra name.

Closes #1363.

Closes #1399.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 16, 2024
@zanieb
Copy link
Member

zanieb commented Feb 16, 2024

We ought to write a scenario for this, can you add one to extras.json or open an issue to do so?

@charliermarsh charliermarsh enabled auto-merge (squash) February 16, 2024 04:57
@charliermarsh charliermarsh merged commit 958e88d into main Feb 16, 2024
7 checks passed
@charliermarsh charliermarsh deleted the charlie/none branch February 16, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some existing packages have unexpected extra names Install fails with Failed to download: fastapi==0.10.1
2 participants