Respect .python-version in uv venv --preview
#4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jun 17, 2024
| 3.8.18 | ||
| 3.9.18 | ||
| 3.10.13 | ||
| 3.11.7 | ||
| 3.12.1 |
There was a problem hiding this comment.
Reversed the ordering here because we want this to be the "first" version we use.
konstin
approved these changes
Jun 17, 2024
zanieb
force-pushed
the
zb/toolchain-version-files
branch
from
66f1e5b
to
bea2f20
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
b980669
to
9f00f81
Compare
ibraheemdev
approved these changes
Jun 17, 2024
zanieb
force-pushed
the
zb/toolchain-version-files
branch
from
bea2f20
to
9f711ec
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
9f00f81
to
1233525
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
2 times, most recently
from
9d72e8e
to
80d58f3
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
80d58f3
to
b5199f7
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
b5199f7
to
723091e
Compare
zanieb
force-pushed
the
zb/test-context
branch
11 times, most recently
from
b2a114d
to
43bd971
Compare
zanieb
force-pushed
the
zb/test-context
branch
3 times, most recently
from
e6f41ad
to
10b13f0
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
723091e
to
3867540
Compare
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
It was becoming problematic that the virtual environment test context diverged from the other one i.e. we had to implement filtering twice. This combines the contexts and tweaks the `TestContext` API and filtering mechanisms for Python versions. Combined with my previous changes to the test context at #4364 and #4368 this finally unblocks the snapshots for test cases in #4360 and #4362.
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
3867540
to
5c67d6c
Compare
zanieb
force-pushed
the
zb/toolchain-file-venv
branch
from
5c67d6c
to
f0d74fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading Python version files (introduced in #4335) to
uv venv. If present, we'll use the file version as the default.