Move virtual environment test context into main context #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/test-context
branch
10 times, most recently
from
7680651
to
a0e377e
Compare
zanieb
force-pushed
the
zb/test-context
branch
3 times, most recently
from
4d76cfb
to
b2a114d
Compare
zanieb
commented
Jun 18, 2024
| $Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 10GB | | ||
| $Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 12GB | |
There was a problem hiding this comment.
Windows test builds failed with the mysterious LINK : fatal error LNK1318: Unexpected PDB error; LIMIT without this
zanieb
force-pushed
the
zb/test-context
branch
3 times, most recently
from
60789c6
to
e6f41ad
Compare
charliermarsh
approved these changes
Jun 18, 2024
konstin
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was becoming problematic that the virtual environment test context diverged from the other one i.e. we had to implement filtering twice. This combines the contexts and tweaks the
TestContextAPI and filtering mechanisms for Python versions. Combined with my previous changes to the test context at #4364 and #4368 this finally unblocks the snapshots for test cases in #4360 and #4362.