Revert "Cache downloaded wheel when range requests aren't supported" #6470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d92915.
zanieb
approved these changes
Aug 22, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 25, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.3.1` -> `0.3.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.3.2`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#032) [Compare Source](astral-sh/uv@0.3.1...0.3.2) ##### Configuration - Add support for configuring `python-downloads` with `UV_PYTHON_DOWNLOADS` ([#​6436](astral-sh/uv#6436)) - Add support for configuring the `python-preference` with `UV_PYTHON_PREFERENCE` ([#​6432](astral-sh/uv#6432)) - Deny invalid members in workspace schema ([#​6450](astral-sh/uv#6450)) ##### Performance - Stop streaming wheels when `METADATA` is discovered (if range requests aren't supported) ([#​6470](astral-sh/uv#6470)) ##### Bug fixes - Remove URI type from JSON Schema ([#​6449](astral-sh/uv#6449)) - Fix retrieval of credentials for URLs from cache ([#​6452](astral-sh/uv#6452)) - Restore `cache` suffix on Windows cache path ([#​6482](astral-sh/uv#6482)) - Treat `.pyw` files as scripts in `uv run` on Windows ([#​6453](astral-sh/uv#6453)) - Treat invalid extras as `false` in marker evaluation ([#​6395](astral-sh/uv#6395)) - Avoid overwriting symlinks in `pip compile` output ([#​6487](astral-sh/uv#6487)) ##### Documentation - Add `uv run` hint to the `uvx` guide ([#​6454](astral-sh/uv#6454)) - Add a guide for using uv with FastAPI ([#​6401](astral-sh/uv#6401)) - Add tip for using `managed = false` to disable project management ([#​6465](astral-sh/uv#6465)) - Clarify the `uv tool run`, `uvx`, and `uv run` relationships ([#​6455](astral-sh/uv#6455)) - Fix references to `--python-downloads` (it is `--no-python-downloads`) ([#​6439](astral-sh/uv#6439)) - Further clarifications to the tools documentation ([#​6474](astral-sh/uv#6474)) - Update docs dockerfile (bullseye -> bookworm) ([#​6441](astral-sh/uv#6441)) - Update the installation documentation page ([#​6468](astral-sh/uv#6468)) - Update pip compatibility pages to mention configuration files support ([#​6410](astral-sh/uv#6410)) - Add `uv run` docs for gui scripts ([#​6478](astral-sh/uv#6478)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 7d92915.
I thought this would be a net performance improvement, but we've now had multiple reports that this made locking extremely slow. I also tested this today with a very large codebase against a registry that does not support range requests, and the number of downloads was sort of wild to watch. Reverting the reduced resolution time by over 50%.
Closes #6104.