-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py: Add matplotlib #53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 158 158
=====================================
Hits 158 158
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you indeed put it inside an extras_require
called plot
?
699f5b5
to
56d1087
Compare
Alright, did it :) |
Is this ok? |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
It's imported in psrecord/main.py
The same comment is there for psutil
@JohnAZoidberg - sorry for dropping the ball on this, I've rebased this and fixed the testing |
It's imported in
psrecord/main.py
but not installed by setuptools.Is that okay or do you want it to be optional like this?