setup.py: Add matplotlib #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 158 158
=====================================
Hits 158 158
Continue to review full report at Codecov.
|
astrofrog
requested changes
Jun 28, 2019
JohnAZoidberg
force-pushed
the
matplotlib
branch
from
699f5b5
to
56d1087
Compare
|
Alright, did it :) |
|
Is this ok? |
avalentino
approved these changes
Feb 23, 2021
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
It's imported in psrecord/main.py
The same comment is there for psutil
|
@JohnAZoidberg - sorry for dropping the ball on this, I've rebased this and fixed the testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's imported in
psrecord/main.pybut not installed by setuptools.Is that okay or do you want it to be optional like this?