Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data partitioning #528

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Data partitioning #528

merged 3 commits into from
Jan 12, 2022

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #526

What changes were proposed in this pull request?

This PR does 2 things:

  • compute partitioning columns only if needed
  • fix bug in the path for raw2science_batch

How was this patch tested?

Cloud

@JulienPeloton JulienPeloton added this to the 1.5 milestone Jan 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
83.8% 83.8% Duplication

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #528 (fcb41bc) into master (c6f572f) will decrease coverage by 0%.
The diff coverage is 90%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #528   +/-   ##
=====================================
- Coverage      95%    95%   -1%     
=====================================
  Files          20     20           
  Lines         991    999    +8     
=====================================
+ Hits          944    951    +7     
- Misses         47     48    +1     
Impacted Files Coverage Δ
bin/raw2science.py 95% <90%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f572f...fcb41bc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working partitioning performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[raw2science] Compute the timestamp if this is not present in the data
1 participant