Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag featureless events #364

Merged
merged 3 commits into from Jan 5, 2024
Merged

Flag featureless events #364

merged 3 commits into from Jan 5, 2024

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #363

What changes were proposed in this pull request?

Assign probability of -1.0 for events with null features. Only affects elasticc.

How was this patch tested?

CI

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2a21711) 56.40% compared to head (3ec6a75) 56.20%.

❗ Current head 3ec6a75 differs from pull request most recent head ffc93a3. Consider uploading reports for the commit ffc93a3 to get more accurate results

Files Patch % Lines
fink_science/random_forest_snia/processor.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   56.40%   56.20%   -0.21%     
==========================================
  Files          36       36              
  Lines        1631     1637       +6     
==========================================
  Hits          920      920              
- Misses        711      717       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulienPeloton JulienPeloton merged commit 16ac6d7 into master Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Early SN Ia: flag featureless events
2 participants