Refactor to allow for more flexibility and customization options in the future #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreyfus92
reviewed
May 3, 2024
| @@ -12,9 +13,31 @@ type Props = { | |||
| title: string; | |||
| description: string; | |||
| heroImage?: string; | |||
| posts: [] | |||
There was a problem hiding this comment.
Suggested change
| posts: [] | |
| posts: BlogPost[] |
There was a problem hiding this comment.
added in newest commit where i am now actually duplicating some of the astroDB runtime types for the DB tables. 🎉 and implemented your suggestion as well
… data used on multiple pages instead of just a string
|
These changes are great, they will make it a lot easier to migrate towards ATP. LGTM! 🚀 |
dreyfus92
reviewed
May 3, 2024
Comment on lines
+146
to
+153
| //@ts-ignore | ||
| const htmlContent = await renderMarked(markdownContent.value); | ||
| //@ts-ignore | ||
| htmlPreview.innerHTML = htmlContent; | ||
| } else if (Config.contentRenderer === 'markdoc') { | ||
| //@ts-ignore | ||
| const htmlContent = await renderMarkDoc(markdownContent.value); | ||
| //@ts-ignore |
There was a problem hiding this comment.
what's the issue with ts here?
Comment on lines
+140
to
+147
| //@ts-ignore | ||
| const htmlContent = await renderMarked(markdownContent.value); | ||
| //@ts-ignore | ||
| htmlPreview.innerHTML = htmlContent; | ||
| } else if (Config.contentRenderer === 'markdoc') { | ||
| //@ts-ignore | ||
| const htmlContent = await renderMarkDoc(markdownContent.value); | ||
| //@ts-ignore |
Comment on lines
+140
to
+147
| //@ts-ignore | ||
| const htmlContent = await renderMarked(markdownContent.value); | ||
| //@ts-ignore | ||
| htmlPreview.innerHTML = htmlContent; | ||
| } else if (Config.contentRenderer === 'markdoc') { | ||
| //@ts-ignore | ||
| const htmlContent = await renderMarkDoc(markdownContent.value); | ||
| //@ts-ignore |
Comment on lines
+148
to
+155
| //@ts-ignore | ||
| const htmlContent = await renderMarked(markdownContent.value); | ||
| //@ts-ignore | ||
| htmlPreview.innerHTML = htmlContent; | ||
| } else if (Config.contentRenderer === 'markdoc') { | ||
| //@ts-ignore | ||
| const htmlContent = await renderMarkDoc(markdownContent.value); | ||
| //@ts-ignore |
|
!coauthor |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on topics discussed during the discord community call on May 1, 2024.
It adds a few useful tricks into the mix including moving the content render into a virtual component that is exported as well as setting up a proper d.ts file export using the AIK addDts() utility to allow the recognition of the new Virtual component Utilities "studiocms:components" as well as reorganizing the page routes as a start to creating a more flexible setup for the future!