Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added condition based on custom config #332

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Conversation

rishkarajgi
Copy link
Contributor

Description

Loads external vector config from secrets if customConfig flag is enabled

Related Issues

https://github.com/astronomer/issues/issues/4733

Testing

Do not merge this PR until this text is replaced with details about how these changes were tested.

Merging

0.29.2

Copy link
Contributor

@pgvishnuram pgvishnuram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configs are validated

@pgvishnuram
Copy link
Contributor

@danielhoherd @jedcunningham - post your comments in here

Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. I left a few comments that I'd like to see answers for.

@rishkarajgi
Copy link
Contributor Author

Looks mostly good. I left a few comments that I'd like to see answers for.

@danielhoherd PTAL

Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the yaml whitespace inconsistencies, which aren't a show-stopper.

@rishkarajgi rishkarajgi merged commit 92aa431 into master Jun 28, 2022
@rishkarajgi rishkarajgi deleted the custom-vector-config branch June 28, 2022 21:22
@rishkarajgi rishkarajgi restored the custom-vector-config branch June 29, 2022 09:40
@rishkarajgi rishkarajgi mentioned this pull request Jun 29, 2022
@rishkarajgi rishkarajgi deleted the custom-vector-config branch June 29, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants