-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added condition based on custom config #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configs are validated
@danielhoherd @jedcunningham - post your comments in here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. I left a few comments that I'd like to see answers for.
@danielhoherd PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the yaml whitespace inconsistencies, which aren't a show-stopper.
Description
Loads external vector config from secrets if customConfig flag is enabled
Related Issues
https://github.com/astronomer/issues/issues/4733
Testing
Do not merge this PR until this text is replaced with details about how these changes were tested.
Merging
0.29.2