[BUGFIX] Fix error with the instantiation of a Checkpoint from a CheckpointConfig #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenwade4
reviewed
Feb 2, 2022
cdkini
approved these changes
Feb 2, 2022
Comment on lines
144
to
146
| # self.checkpoint = Checkpoint( | ||
| # data_context=self.data_context, **self.checkpoint_config.to_json_dict() | ||
| # ) |
There was a problem hiding this comment.
Should we get rid of this commented out code in place of the new pattern?
There was a problem hiding this comment.
Already done! Changes just pushed.
kenwade4
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes to the signature of the Checkpoint class, an error was being thrown when instantiating a Checkpoint from a Checkpoint Config. This PR updates the method of instantiation to use
instantiate_class_from_configwhich is a more appropriate means of doing this.It also contains changes necessary for the release of a new version.