Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic local dev script #18

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add basic local dev script #18

merged 2 commits into from
Oct 18, 2023

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Oct 12, 2023

closes: #30

Add a simple script and document to run the API server, UI and generate env template for API server

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98c7369
Status: ✅  Deploy successful!
Preview URL: https://2be95042.ask-astro.pages.dev
Branch Preview URL: https://local-dev.ask-astro.pages.dev

View logs

@Lee-W
Copy link
Collaborator

Lee-W commented Oct 13, 2023

in addition to required env vars, we'll also need to setup gcp.json and GOOGLE_APPLICATION_CREDENTIALS
https://cloud.google.com/docs/authentication/application-default-credentials
cc @sunank200

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we review dockerfile with env here? And how does one set env? Another thing to consider is a local dev story for the slack app. You can use something like this to forward the port for slackbot: https://ngrok.com/docs/secure-tunnels/non-local/#:~:text=Forwarding%20to%20servers%20on%20a,network%20address%20and%20port%20instead.

@pankajastro pankajastro force-pushed the local-dev branch 2 times, most recently from 939760d to 42c92c8 Compare October 17, 2023 19:25
@pankajastro pankajastro marked this pull request as ready for review October 17, 2023 19:26
scripts/local_dev.py Outdated Show resolved Hide resolved
@sunank200 sunank200 added this to the 0.0.1 milestone Oct 18, 2023
@pankajastro
Copy link
Collaborator Author

in addition to required env vars, we'll also need to setup gcp.json and GOOGLE_APPLICATION_CREDENTIALS https://cloud.google.com/docs/authentication/application-default-credentials cc @sunank200

Yes, But don't want to checkin the copy command so added a comment in dockerfile also added a way to generate template for env require in API

@pankajastro
Copy link
Collaborator Author

Don't we review dockerfile with env here? And how does one set env? Another thing to consider is a local dev story for the slack app. You can use something like this to forward the port for slackbot: https://ngrok.com/docs/secure-tunnels/non-local/#:~:text=Forwarding%20to%20servers%20on%20a,network%20address%20and%20port%20instead.

Added way to generate a template for env. slack part will be addressed #42

@pankajastro
Copy link
Collaborator Author

pankajastro commented Oct 18, 2023

Merging since I need for #39. feel free to post feedback will take in a separate PR

@pankajastro pankajastro merged commit a4a7259 into main Oct 18, 2023
2 checks passed
@pankajastro pankajastro deleted the local-dev branch October 18, 2023 12:12
@sunank200
Copy link
Collaborator

Lets not merge this PR before approval please @pankajastro

@sunank200
Copy link
Collaborator

This PR has better approach of local dev story: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Local Development for Ask-Astro Project
3 participants