Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup and run end to end #42

Merged
merged 13 commits into from
Oct 20, 2023
Merged

Setup and run end to end #42

merged 13 commits into from
Oct 20, 2023

Conversation

Lee-W
Copy link
Collaborator

@Lee-W Lee-W commented Oct 17, 2023

The main change is documenting how to set the slack bot for ask-astro https://github.com/astronomer/ask-astro/blob/setup-and-run-end-to-end/docs/api/setup_slack_bot.md

Other are minor improvement and scripts to run ask-astro API locally

Closes: #32 #38

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 407af09
Status: ✅  Deploy successful!
Preview URL: https://3ec5a591.ask-astro.pages.dev
Branch Preview URL: https://setup-and-run-end-to-end.ask-astro.pages.dev

View logs

@Lee-W Lee-W marked this pull request as ready for review October 18, 2023 04:12
@sunank200 sunank200 added this to the 0.0.1 milestone Oct 18, 2023
@Lee-W Lee-W mentioned this pull request Oct 18, 2023
4 tasks
@Lee-W Lee-W self-assigned this Oct 18, 2023
Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all looks good to me. Following needs to be added.

  1. Installation of poetry and missing requirements if any.

.gitignore Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tasks.py Outdated Show resolved Hide resolved
@Lee-W
Copy link
Collaborator Author

Lee-W commented Oct 20, 2023

Over all looks good to me. Following needs to be added.

1. Installation of poetry and missing requirements if any.

could be improved but this is how it looks like now

image

Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sunank200 sunank200 merged commit 1ce5b95 into main Oct 20, 2023
3 checks passed
@sunank200 sunank200 deleted the setup-and-run-end-to-end branch October 20, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup and run Ask-Astro end to end
3 participants