Add missing check on error return from docker log in step (#325)

astronomer · Apr 9, 2020 · 7ba67c8 · 7ba67c8
1 parent 105ffb0
commit 7ba67c8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/docker/docker.go b/docker/docker.go
@@ -108,7 +108,10 @@ func ExecLogin(serverAddress, username, token string) error {
 		RegistryToken: token,
 	}
 
-	response, _ = cli.RegistryLogin(ctx, types.AuthConfig(*authConfig))
+	response, err = cli.RegistryLogin(ctx, types.AuthConfig(*authConfig))
+	if err != nil {
+		return errors.Errorf("error saving credentials: %v", err)
+	}
 
 	// Get this idea from docker login cli
 	authConfig.RegistryToken = ""