Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing check on error return from docker log in step #325

Merged
merged 2 commits into from Apr 9, 2020
Merged

Add missing check on error return from docker log in step #325

merged 2 commits into from Apr 9, 2020

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Apr 9, 2020

No description provided.

andriisoldatenko
andriisoldatenko reviewed Apr 9, 2020
View reviewed changes
docker/docker.go Outdated Show resolved Hide resolved
@ashb
Copy link
Contributor Author

ashb commented Apr 9, 2020

This error doesn't seem to appear though. But with this change the docker step fails with:

Failed to authenticate to the registry, this can occur when registry is offline. Until authenticated you will not be able to push new images to your Airflow clusters

@ashb ashb merged commit 7ba67c8 into master Apr 9, 2020
@ashb ashb deleted the add-missing-error-check branch April 9, 2020 22:43
@andriisoldatenko andriisoldatenko mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriisoldatenko andriisoldatenko andriisoldatenko approved these changes

@schnie schnie Awaiting requested review from schnie schnie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashb @andriisoldatenko