Silence go-critic warnings

astronomer · May 8, 2023 · f6435f8 · f6435f8
1 parent fc741e1
commit f6435f8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/airflow/docker_test.go b/airflow/docker_test.go
@@ -1626,9 +1626,10 @@ func (s *Suite) TestCreateDockerProject() {
 		s.NoError(err)
 		postgresService := types.ServiceConfig{}
 		serviceFound := false
-		for _, service := range prj.Services {
+		for i := range prj.Services {
+			service := &prj.Services[i]
 			if service.Name == "webserver" {
-				postgresService = service
+				postgresService = *service
 				serviceFound = true
 				break
 			}
@@ -1643,9 +1644,10 @@ func (s *Suite) TestCreateDockerProject() {
 		s.NoError(err)
 		postgresService := types.ServiceConfig{}
 		serviceFound := false
-		for _, service := range prj.Services {
+		for i := range prj.Services {
+			service := &prj.Services[i]
 			if service.Name == "postgres" {
-				postgresService = service
+				postgresService = *service
 				serviceFound = true
 				break
 			}

diff --git a/pkg/printutil/printutil_test.go b/pkg/printutil/printutil_test.go
@@ -72,7 +72,8 @@ func (s *Suite) TestTablePrint() {
 			wantErr: false,
 		},
 	}
-	for _, tt := range tests {
+	for i := range tests {
+		tt := &tests[i]
 		s.Run(tt.name, func() {
 			tr := &Table{
 				Padding:         tt.fields.Padding,
@@ -132,7 +133,8 @@ func (s *Suite) TestTablePrintWithIndex() {
 			wantErr: false,
 		},
 	}
-	for _, tt := range tests {
+	for i := range tests {
+		tt := &tests[i]
 		s.Run(tt.name, func() {
 			tr := &Table{
 				Padding:         tt.fields.Padding,
@@ -184,7 +186,8 @@ func (s *Suite) TestTablePrintHeader() {
 			wantOut: "testing",
 		},
 	}
-	for _, tt := range tests {
+	for i := range tests {
+		tt := &tests[i]
 		s.Run(tt.name, func() {
 			tr := &Table{
 				Padding:         tt.fields.Padding,
@@ -233,7 +236,8 @@ func (s *Suite) TestTablePrintRows() {
 			wantOut: "testing",
 		},
 	}
-	for _, tt := range tests {
+	for i := range tests {
+		tt := &tests[i]
 		s.Run(tt.name, func() {
 			tr := &Table{
 				Padding:         tt.fields.Padding,