Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported inline comment from .gitignore #1498

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

BasPH
Copy link
Contributor

@BasPH BasPH commented Jan 26, 2024

Description

.gitignore files do not support inline comments, these will be interpreted as a pattern. Therefore, the .DS_Store file wasn't ignored in Astro projects. This PR removes the comment which ignores .DS_Store files.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d88204d) 85.94% compared to head (582cf6a) 85.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files         115      115           
  Lines       15053    15053           
=======================================
  Hits        12938    12938           
  Misses       1272     1272           
  Partials      843      843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit e125d73 into main Jan 26, 2024
5 checks passed
@kushalmalani kushalmalani deleted the fix-gitignore branch January 26, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants