Add compose export error #1505
Merged
Add compose export error #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
neel-astro,
kushalmalani,
vandyliu,
jwitz and
lzdanski
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
=======================================
Coverage 85.92% 85.93%
=======================================
Files 112 112
Lines 14911 14913 +2
=======================================
+ Hits 12813 12815 +2
Misses 1264 1264
Partials 834 834 ☔ View full report in Codecov by Sentry. |
vandyliu
reviewed
Jan 30, 2024
| @@ -932,6 +933,9 @@ func airflowSettingsExport(cmd *cobra.Command, args []string) error { | |||
| fmt.Println("Exporting compose file to " + exportComposeFile) | |||
| return containerHandler.ComposeExport(settingsFile, exportComposeFile) | |||
| } | |||
| if !compose && cmd.Flags().Changed("compose-file") { | |||
There was a problem hiding this comment.
can we add a simple unit test for this case
|
blocked by not being able to get a test working with |
kushalmalani
approved these changes
Feb 5, 2024
kushalmalani
pushed a commit
that referenced
this pull request
Feb 7, 2024
* add compose export error * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an error for when --compose-file is used without --compose
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft