Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core clients and update workspace api token to work with new client #1540

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Feb 9, 2024

Description

This PR updates the core clients used in the CLI and then fixes any breaking changes

Describe the purpose of this pull request.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

All existing unit tests should still pass the same

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vandyliu vandyliu marked this pull request as ready for review February 9, 2024 17:47
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eed9407) 86.06% compared to head (5b15192) 86.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1540   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         112      112           
  Lines       14915    14916    +1     
=======================================
+ Hits        12836    12837    +1     
  Misses       1258     1258           
  Partials      821      821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr
Copy link
Contributor

sunkickr commented Feb 9, 2024

Seems like a simple update

@vandyliu vandyliu merged commit b39322b into main Feb 9, 2024
5 checks passed
@vandyliu vandyliu deleted the update-core-clients-and-fix-bug branch February 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants