Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment related error messages #1555

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

feluelle
Copy link
Member

Description

Describe the purpose of this pull request.

Improve deployment-related error messages, fix typos, and remove unused ones.

cc @paolaperaza

🎟 Issue(s)

Related #1537 (review)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@feluelle feluelle self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f47a24a) 86.16% compared to head (91b9479) 86.16%.
Report is 1 commits behind head on main.

Files Patch % Lines
cloud/deployment/deployment.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files         112      112           
  Lines       14952    14952           
=======================================
  Hits        12883    12883           
  Misses       1251     1251           
  Partials      818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaxil kaxil merged commit 8cd2328 into main Feb 21, 2024
3 of 5 checks passed
@kaxil kaxil deleted the fix/deployment-error-messages branch February 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants