Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate core clients to be compatible with the latest changes #1566

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Regenerate core clients to be compatible with the latest changes #1566

merged 1 commit into from
Feb 27, 2024

Conversation

feluelle
Copy link
Member

@feluelle feluelle commented Feb 26, 2024 •
edited

Description

Describe the purpose of this pull request.

Regenerate core clients to be compatible with the latest changes (see related issue below).

  • fix hibernation override validation
  • fix cloudprovider references

Regenerated using astro branch release/20240227 and make generate

🎟 Issue(s)

Related https://github.com/astronomer/astro/pull/19518

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@feluelle feluelle force-pushed the fix/hibernation-override-validation branch from 68ff5f6 to 47d0b93 Compare February 26, 2024 12:43
@feluelle feluelle self-assigned this Feb 26, 2024
@feluelle
Regenerate core clients to be compatible with the latest changes
04f9114 
- fix hibernation override validation
- fix cloudprovider references
@feluelle feluelle force-pushed the fix/hibernation-override-validation branch from 47d0b93 to 04f9114 Compare February 26, 2024 12:48
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (81b3793) to head (04f9114).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1566   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files         113      113           
  Lines       15668    15668           
=======================================
  Hits        13540    13540           
  Misses       1280     1280           
  Partials      848      848

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feluelle feluelle marked this pull request as draft February 26, 2024 13:04
@feluelle feluelle marked this pull request as ready for review February 26, 2024 16:27
kushalmalani
kushalmalani approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@kushalmalani kushalmalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be part of 1.24.0 release?

feluelle
feluelle commented Feb 26, 2024
View reviewed changes
cloud/deployment/inspect/inspect_test.go
@@ -825,7 +825,7 @@ func TestFormatPrintableDeployment(t *testing.T) {
scheduler_count: 3
workspace_name: test-ws
deployment_type: STANDARD
cloud_provider: azure
cloud_provider: AZURE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a change worth documenting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is a breaking change if users are using the output of an old template to generate a deployment? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC: @sunkickr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should validate that "azure" still works as an input but yeah the output changing doesn't matter

@feluelle
Copy link
Member Author

feluelle commented Feb 26, 2024 •
edited

Does this need to be part of 1.24.0 release?

Yes, because the hibernation override input type changed from expecting a bool to a bool ptr.

EDIT: It only changed for the response, which I think is not breaking then, but we should still include it in 1.24.0

@kushalmalani kushalmalani merged commit c0356b8 into main Feb 27, 2024
4 of 5 checks passed
@kushalmalani kushalmalani deleted the fix/hibernation-override-validation branch February 27, 2024 02:11
kushalmalani pushed a commit that referenced this pull request Feb 27, 2024
@feluelle @kushalmalani
Regenerate core clients to be compatible with the latest changes (#1566)
61efb70 
- fix hibernation override validation
- fix cloudprovider references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalmalani kushalmalani kushalmalani approved these changes

@ashb ashb ashb approved these changes

@vandyliu vandyliu vandyliu approved these changes

@neel-astro neel-astro Awaiting requested review from neel-astro neel-astro is a code owner

@sunkickr sunkickr Awaiting requested review from sunkickr sunkickr is a code owner

Assignees

@feluelle feluelle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@feluelle @ashb @vandyliu @sunkickr @kushalmalani