Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deployment variable create #1605

Merged
merged 2 commits into from Mar 27, 2024
Merged

fix deployment variable create #1605

merged 2 commits into from Mar 27, 2024

Conversation

sunkickr
Copy link
Contributor

Description

Fix the issue with deployment variable create where it cuts off the value at the first "=" character

🎟 Issue(s)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (6b79c3d) to head (6e9de85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files         114      114           
  Lines       15944    15944           
=======================================
  Hits        13804    13804           
  Misses       1284     1284           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani
Copy link
Contributor

Can we add some unit tests and if we can test it manually too?

@sunkickr
Copy link
Contributor Author

@kushalmalani Iv tested this manually

@sunkickr sunkickr marked this pull request as ready for review March 25, 2024 16:57
@sunkickr
Copy link
Contributor Author

sunkickr commented Mar 26, 2024

@kushalmalani I added a new test

Copy link
Contributor

@kushalmalani kushalmalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the unit test

@sunkickr sunkickr merged commit a9f4c7c into main Mar 27, 2024
4 of 5 checks passed
@sunkickr sunkickr deleted the fix-var-create branch March 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants