fix error-code #1646
Merged
fix error-code #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
=======================================
Coverage 86.76% 86.77%
=======================================
Files 114 114
Lines 16693 16697 +4
=======================================
+ Hits 14483 14488 +5
Misses 1323 1323
+ Partials 887 886 -1 ☔ View full report in Codecov by Sentry. |
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
kushalmalani
reviewed
May 9, 2024
airflow/docker.go
Outdated
| @@ -703,13 +707,13 @@ func (d *DockerCompose) versionTest(testHomeDirectory, currentAirflowVersion, de | |||
| return nil | |||
| } | |||
|
|
|||
| func (d *DockerCompose) dagTest(testHomeDirectory, newAirflowVersion, newDockerFile, customImage, buildSecretString string) error { | |||
| func (d *DockerCompose) dagTest(testHomeDirectory, newAirflowVersion, newDockerFile, customImage, buildSecretString string) (string, error) { | |||
There was a problem hiding this comment.
Can we return an int instead of a string?
There was a problem hiding this comment.
The exit code is parsed from the docker logs so it ends up as a string
kushalmalani
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade-test command doesn't return an exit code of 1 when the DAG parse test fails. This makes it so the failures doesn't stop their CI/CD pipeline
🎟 Issue(s)
🧪 Functional Testing
manual testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft