Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if_exists='append' in not respected in Snowflake database #729

Closed
utkarsharma2 opened this issue Aug 23, 2022 · 0 comments · Fixed by #730
Closed

if_exists='append' in not respected in Snowflake database #729

utkarsharma2 opened this issue Aug 23, 2022 · 0 comments · Fixed by #730
Assignees

Comments

@utkarsharma2
Copy link
Collaborator

Describe the bug
Even if we have passed if_exists='append' we are still trying to create a table.

Version

  • Astro: 1.0.0

To Reproduce
Steps to reproduce the behavior:
Try load_file with if_exists='append' the operator will still try to create a table.

Expected behavior
When if_exists='append' AstroSDK should not create a table.

utkarsharma2 added a commit that referenced this issue Aug 23, 2022
…able" (#730)

# Description
## What is the current behavior?
Even if we have passed if_exists='append' we are still trying to create a table.

closes: #729 

## What is the new behavior?
We check for if_exists=='replace' and only create a table in this case.

## Does this introduce a breaking change?
Nope

### Checklist
- [X] Created tests that fail without the change (if possible)
- [X] Extended the README/documentation, if necessary
kaxil pushed a commit that referenced this issue Aug 23, 2022
…able" (#730)

# Description
## What is the current behavior?
Even if we have passed if_exists='append' we are still trying to create a table.

closes: #729

## What is the new behavior?
We check for if_exists=='replace' and only create a table in this case.

## Does this introduce a breaking change?
Nope

### Checklist
- [X] Created tests that fail without the change (if possible)
- [X] Extended the README/documentation, if necessary

(cherry picked from commit 37d7618)
@utkarsharma2 utkarsharma2 self-assigned this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant