Update snowflake-sqlalchemy version #1228
Conversation
Codecov ReportBase: 93.81% // Head: 94.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
==========================================
+ Coverage 93.81% 94.72% +0.90%
==========================================
Files 18 70 +52
Lines 582 3201 +2619
Branches 62 368 +306
==========================================
+ Hits 546 3032 +2486
- Misses 24 106 +82
- Partials 12 63 +51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -62,7 +62,7 @@ google = [ | |||
| ] | |||
| snowflake = [ | |||
| "apache-airflow-providers-snowflake", | |||
| "snowflake-sqlalchemy>=1.2.0,<=1.2.4", | |||
| "snowflake-sqlalchemy>=1.2.0", | |||
There was a problem hiding this comment.
Not sure why this was restricted but because of this when we are installing astro-sdk with airflow constraints file getting below error
The conflict is caused by:
astro-sdk-python[amazon,google,postgres,snowflake] 1.0.0 depends on snowflake-sqlalchemy<=1.2.4 and >=1.2.0; extra == "snowflake"
The user requested (constraint) snowflake-sqlalchemy==1.4.2
There was a problem hiding this comment.
related to #1185 cc @utkarsharma2
There was a problem hiding this comment.
In #1185 look like we have changed SQLAlchemy only so snowflake-sqlalchemy version was restricted even before
There was a problem hiding this comment.
Also look like import issue has been fixed in latest release https://github.com/snowflakedb/snowflake-sqlalchemy/releases/tag/v1.4.3
There was a problem hiding this comment.
Cool. Could you remove the version restriction there then as well? I think there is then no reason to limit that version.
It is directly related so I think it makes sense to change both together.
pankajastro
changed the title
pankajastro
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajkoti and
feluelle
as code owners
pankajastro
force-pushed
the
update_sqlalchemy_version
branch
from
6c06b4f
to
407d572
Compare
# Description ## What is the current behavior? closes: #1226 closes: #1187 ## What is the new behavior? Remove snowflake-sqlalchemy version restrion ## Does this introduce a breaking change? ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary (cherry picked from commit 28188c8)
Description
What is the current behavior?
closes: #1226
closes: #1187
What is the new behavior?
Remove snowflake-sqlalchemy version restrion
Does this introduce a breaking change?
Checklist