Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error db mismatch of operation #1233

Merged
merged 15 commits into from
Nov 16, 2022
Merged

Raise error db mismatch of operation #1233

merged 15 commits into from
Nov 16, 2022

Conversation

pankajastro
Copy link
Contributor

Description

What is the current behavior?

closes: #1147

What is the new behavior?

Raise expectation if the input and output DB source is not the same

Does this introduce a breaking change?

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 94.13% // Head: 94.79% // Increases project coverage by +0.65% 🎉

Coverage data is based on head (520a579) compared to base (c74dc2a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
+ Coverage   94.13%   94.79%   +0.65%     
==========================================
  Files          17       69      +52     
  Lines         597     3226    +2629     
  Branches       67      377     +310     
==========================================
+ Hits          562     3058    +2496     
- Misses         22      104      +82     
- Partials       13       64      +51     
Impacted Files Coverage Δ
python-sdk/src/astro/sql/operators/append.py 96.00% <100.00%> (ø)
...thon-sdk/src/astro/sql/operators/base_decorator.py 95.00% <100.00%> (ø)
python-sdk/src/astro/sql/operators/merge.py 96.15% <100.00%> (ø)
python-sdk/src/astro/table.py 100.00% <100.00%> (ø)
python-sdk/src/astro/utils/typing_compat.py 100.00% <0.00%> (ø)
python-sdk/src/astro/files/__init__.py 83.33% <0.00%> (ø)
python-sdk/src/astro/utils/table.py 94.28% <0.00%> (ø)
python-sdk/src/astro/sql/__init__.py 95.23% <0.00%> (ø)
python-sdk/src/astro/sql/operators/export_file.py 94.23% <0.00%> (ø)
python-sdk/src/astro/airflow/datasets.py 85.71% <0.00%> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pankajastro pankajastro changed the title Handle db mismatch [WIP] Handle db mismatch Nov 10, 2022
@pankajastro pankajastro force-pushed the handle_db_mismatch branch 3 times, most recently from 3684cee to 1e0163f Compare November 11, 2022 19:44
@pankajastro pankajastro changed the title [WIP] Handle db mismatch Raise error db mismatch of operation Nov 14, 2022
@pankajastro pankajastro marked this pull request as ready for review November 14, 2022 06:28
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please consider the minor suggestions.

python-sdk/src/astro/sql/operators/append.py Outdated Show resolved Hide resolved
python-sdk/src/astro/sql/operators/base_decorator.py Outdated Show resolved Hide resolved
python-sdk/src/astro/sql/operators/merge.py Outdated Show resolved Hide resolved
python-sdk/tests/sql/operators/test_append.py Outdated Show resolved Hide resolved
python-sdk/tests/sql/operators/test_merge.py Outdated Show resolved Hide resolved
python-sdk/tests/sql/operators/transform/test_transform.py Outdated Show resolved Hide resolved
python-sdk/src/astro/sql/operators/append.py Outdated Show resolved Hide resolved
python-sdk/src/astro/sql/operators/base_decorator.py Outdated Show resolved Hide resolved
python-sdk/src/astro/sql/operators/merge.py Outdated Show resolved Hide resolved
@pankajastro pankajastro merged commit a99f949 into main Nov 16, 2022
@pankajastro pankajastro deleted the handle_db_mismatch branch November 16, 2022 07:06
kaxil pushed a commit that referenced this pull request Nov 16, 2022
# Description
## What is the current behavior?
closes: #1147

## What is the new behavior?
Raise expectation if the input and output DB source is not the same

## Does this introduce a breaking change?

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

(cherry picked from commit a99f949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying table of different DB in Output_table param fails silently
2 participants