Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_file_list_func to users #1380

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Expose get_file_list_func to users #1380

merged 1 commit into from
Dec 8, 2022

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Dec 7, 2022

This exposes get_file_list_func to users so that they can use it in @task or @task.virtualenv

Context: https://astronomer.slack.com/archives/C02B8SPT93K/p1670408501306539?thread_ts=1669893212.365849&cid=C02B8SPT93K

This exposes `get_file_list_func` to users so that they can use it in `@task` or `@task.virtualenv`
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 97.36% // Head: 93.13% // Decreases project coverage by -4.22% ⚠️

Coverage data is based on head (720caef) compared to base (6db1977).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   97.36%   93.13%   -4.23%     
==========================================
  Files          19       54      +35     
  Lines         683     2855    +2172     
  Branches        0      337     +337     
==========================================
+ Hits          665     2659    +1994     
- Misses         18      130     +112     
- Partials        0       66      +66     
Impacted Files Coverage Δ
python-sdk/src/astro/files/__init__.py 83.33% <100.00%> (ø)
python-sdk/src/astro/files/operators/files.py 100.00% <100.00%> (ø)
sql-cli/sql_cli/constants.py
sql-cli/sql_cli/astro/command.py
sql-cli/sql_cli/exceptions.py
sql-cli/sql_cli/project.py
sql-cli/sql_cli/astro/group.py
sql-cli/sql_cli/run_dag.py
sql-cli/sql_cli/operators/load_file.py
sql-cli/sql_cli/__init__.py
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaxil kaxil merged commit bf0d3cd into main Dec 8, 2022
@kaxil kaxil deleted the expose-get_file-func branch December 8, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants