Fix output property missing for airflow version < 2.4.0 #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
requested review from
dimberman,
tatiana,
utkarsharma2,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov ReportBase: 93.87% // Head: 93.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 93.87% 93.82% -0.05%
==========================================
Files 78 78
Lines 3673 3678 +5
Branches 355 355
==========================================
+ Hits 3448 3451 +3
- Misses 153 155 +2
Partials 72 72
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
feluelle
reviewed
Dec 7, 2022
kaxil
reviewed
Dec 7, 2022
sunank200
force-pushed
the
cleanup-fix
branch
from
d2b5a18
to
5dda7d5
Compare
feluelle
approved these changes
Dec 9, 2022
kaxil
reviewed
Dec 9, 2022
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
sunank200
force-pushed
the
cleanup-fix
branch
from
93ddb10
to
bbca90c
Compare
for more information, see https://pre-commit.ci
kaxil
approved these changes
Dec 9, 2022
kaxil
pushed a commit
that referenced
this pull request
Dec 13, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The output was implemented in 2.4.0 according to the release notes (see [here](https://airflow.apache.org/docs/apache-airflow/stable/release_notes.html#id13)) Add output property to MappedOperator apache/airflow#25604 <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #1359 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Catch exception for airflow version < 2.4.0 and use `XComArg(...)` instead. ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 0f5ff62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
The output was implemented in 2.4.0 according to the release notes (see here)
Add output property to MappedOperator apache/airflow#25604
closes: #1359
What is the new behavior?
XComArg(...)instead.Does this introduce a breaking change?
No
Checklist