Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output property missing for airflow version < 2.4.0 #1385

Merged
merged 14 commits into from
Dec 12, 2022
Merged

Fix output property missing for airflow version < 2.4.0 #1385

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d2b5a18
Fix output property missing for airflow version < 2.4.0
sunank200 Dec 7, 2022
5dda7d5
Fix output property missing for airflow version < 2.4.0
sunank200 Dec 7, 2022
92c801e
Merge branch 'main' into cleanup-fix
sunank200 Dec 9, 2022
c110a8b
Merge branch 'cleanup-fix' of https://github.com/astronomer/astro-sdk…
sunank200 Dec 9, 2022
1bea754
Remove the for loop
sunank200 Dec 9, 2022
230add9
Remove try except and use Version
sunank200 Dec 9, 2022
76ff51b
Fix output property missing for airflow version < 2.4.0
sunank200 Dec 7, 2022
15f5a07
Remove the for loop
sunank200 Dec 9, 2022
24e7f7d
Remove try except and use Version
sunank200 Dec 9, 2022
bbca90c
Update python-sdk/src/astro/sql/operators/cleanup.py
sunank200 Dec 9, 2022
7bebd31
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2022
c92265a
Merge branch 'main' into cleanup-fix
sunank200 Dec 9, 2022
483bd0b
resolve merge conflict
sunank200 Dec 9, 2022
8e45c7b
Merge branch 'main' into cleanup-fix
sunank200 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion python-sdk/src/astro/sql/operators/cleanup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,14 @@ def resolve_tables_from_tasks( # noqa: C901
and isinstance(task, MappedOperator)
and issubclass(task.operator_class, OPERATOR_CLASSES_WITH_TABLE_OUTPUT)
):
for t in task.output.resolve(context):
from airflow.models.xcom_arg import XComArg

try:
task_output = task.output
except AttributeError:
task_output = XComArg(operator=task)

for t in task_output.resolve(context):
if isinstance(t, BaseTable):
res.append(t)
except AirflowException: # pragma: no cover
Expand Down