Load/export file from Azure blob storage using non-native path #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.00% // Head: 97.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
+ Coverage 94.00% 97.59% +3.58%
==========================================
Files 89 22 -67
Lines 4372 789 -3583
Branches 432 0 -432
==========================================
- Hits 4110 770 -3340
+ Misses 178 19 -159
+ Partials 84 0 -84 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tatiana
changed the title
tatiana
changed the title
tatiana
force-pushed
the
python-sdk/1447
branch
3 times, most recently
from
3daee33
to
04ec544
Compare
tatiana
changed the title
tatiana
force-pushed
the
python-sdk/1447
branch
6 times, most recently
from
f4c0564
to
bc0603f
Compare
tatiana
requested review from
dimberman,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
pankajastro
approved these changes
Jan 9, 2023
Closes: #1447 Co-authored-by: Luan Moreno <luan.moreno@owshq.com> Co-authored-by: Mateus Oliveira <mateus.oliveira@owshq.com>
tatiana
force-pushed
the
python-sdk/1447
branch
from
03bb23b
to
1aa990b
Compare
tatiana
force-pushed
the
python-sdk/1447
branch
from
48d708c
to
62840e1
Compare
|
@pankajastro thanks! There is something very odd going on with our Github actions; it is triggering the jobs but sometimes it's not deploying here 🤔 |
pankajastro
force-pushed
the
python-sdk/1447
branch
from
62840e1
to
c182abf
Compare
I did a force push then it showing up |
tatiana
force-pushed
the
python-sdk/1447
branch
from
32fae0f
to
276b5b4
Compare
tatiana
force-pushed
the
python-sdk/1447
branch
from
24a1edc
to
b28a0b8
Compare
tatiana
force-pushed
the
python-sdk/1447
branch
from
6302f7b
to
e706d98
Compare
for more information, see https://pre-commit.ci
utkarsharma2
pushed a commit
that referenced
this pull request
Jan 17, 2023
Closes: #1447 Bonus: - Improve and standardise `export_to_file` tests related to remote file locations so we have a consistent way of testing them (all file locations x all remote object stores) - Fix the GCS and WASB location `exists` method Pending - Azure + Databricks support (separate ticket) Co-authored-by: Luan Moreno <luan.moreno@owshq.com> Co-authored-by: Mateus Oliveira <mateus.oliveira@owshq.com> Co-authored-by: Luan Moreno <luan.moreno@owshq.com> Co-authored-by: Mateus Oliveira <mateus.oliveira@owshq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1447
Bonus:
export_to_filetests related to remote file locations so we have a consistent way of testing them (all file locations x all remote object stores)existsmethodPending
Co-authored-by: Luan Moreno luan.moreno@owshq.com
Co-authored-by: Mateus Oliveira mateus.oliveira@owshq.com