-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load/export file from Azure blob storage using non-native path #1542
Conversation
Codecov ReportBase: 94.00% // Head: 97.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
+ Coverage 94.00% 97.59% +3.58%
==========================================
Files 89 22 -67
Lines 4372 789 -3583
Branches 432 0 -432
==========================================
- Hits 4110 770 -3340
+ Misses 178 19 -159
+ Partials 84 0 -84 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3daee33
to
04ec544
Compare
f4c0564
to
bc0603f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But look like CI has not triggered on the last commit.
Closes: #1447 Co-authored-by: Luan Moreno <luan.moreno@owshq.com> Co-authored-by: Mateus Oliveira <mateus.oliveira@owshq.com>
03bb23b
to
1aa990b
Compare
48d708c
to
62840e1
Compare
@pankajastro thanks! There is something very odd going on with our Github actions; it is triggering the jobs but sometimes it's not deploying here 🤔 |
62840e1
to
c182abf
Compare
|
32fae0f
to
276b5b4
Compare
24a1edc
to
b28a0b8
Compare
6302f7b
to
e706d98
Compare
for more information, see https://pre-commit.ci
Closes: #1447 Bonus: - Improve and standardise `export_to_file` tests related to remote file locations so we have a consistent way of testing them (all file locations x all remote object stores) - Fix the GCS and WASB location `exists` method Pending - Azure + Databricks support (separate ticket) Co-authored-by: Luan Moreno <luan.moreno@owshq.com> Co-authored-by: Mateus Oliveira <mateus.oliveira@owshq.com> Co-authored-by: Luan Moreno <luan.moreno@owshq.com> Co-authored-by: Mateus Oliveira <mateus.oliveira@owshq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Closes: #1447
Bonus:
export_to_file
tests related to remote file locations so we have a consistent way of testing them (all file locations x all remote object stores)exists
methodPending
Co-authored-by: Luan Moreno luan.moreno@owshq.com
Co-authored-by: Mateus Oliveira mateus.oliveira@owshq.com