Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL support #1801

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Add MySQL support #1801

merged 2 commits into from
Mar 16, 2023

Conversation

phanikumv
Copy link
Collaborator

Description

What is the current behavior?

astro-sdk operators currently do not work with mysql

closes: #627

What is the new behavior?

  • Add mysql support

Does this introduce a breaking change?

No

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 95.29% and project coverage change: +0.18 🎉

Comparison is base (bf189de) 85.72% compared to head (6bc2624) 85.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1801      +/-   ##
==========================================
+ Coverage   85.72%   85.90%   +0.18%     
==========================================
  Files         124      125       +1     
  Lines        6485     6570      +85     
  Branches      643      652       +9     
==========================================
+ Hits         5559     5644      +85     
+ Misses        791      790       -1     
- Partials      135      136       +1     
Flag Coverage Δ
PythonSDK 92.61% <95.29%> (+0.15%) ⬆️
SQL-CLI 97.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python-sdk/src/astro/databases/mysql.py 95.18% <95.18%> (ø)
python-sdk/src/astro/constants.py 96.29% <100.00%> (+1.95%) ⬆️
python-sdk/src/astro/settings.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

python-sdk/example_dags/example_load_file.py Show resolved Hide resolved
python-sdk/src/astro/databases/mysql.py Outdated Show resolved Hide resolved
python-sdk/src/astro/databases/mysql.py Show resolved Hide resolved
@phanikumv phanikumv force-pushed the add-mysql branch 5 times, most recently from c9047ee to b8fd643 Compare March 1, 2023 16:49
@phanikumv phanikumv force-pushed the add-mysql branch 2 times, most recently from a45bc7e to 1bce829 Compare March 9, 2023 07:01
Copy link
Collaborator

@utkarsharma2 utkarsharma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phanikumv phanikumv force-pushed the add-mysql branch 2 times, most recently from d3302a4 to 711f75a Compare March 16, 2023 06:11
@phanikumv phanikumv merged commit ee161d4 into main Mar 16, 2023
@phanikumv phanikumv deleted the add-mysql branch March 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MySQL
4 participants