Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse reusable workflows for rc testing from astronomer-providers #2009

Merged
merged 1 commit into from
Sep 7, 2023
Merged

reuse reusable workflows for rc testing from astronomer-providers #2009

merged 1 commit into from
Sep 7, 2023

Conversation

Lee-W
Copy link
Collaborator

@Lee-W Lee-W commented Aug 11, 2023 •
edited
Loading

Description

What is the current behavior?

Reuse the workflow from astronomer/astronomer-providers#1295 (Will need to wait for its merge)

What is the new behavior?

nothing should be changed

Does this introduce a breaking change?

no

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Lee-W
Copy link
Collaborator Author

Lee-W commented Aug 11, 2023

In addition to BOT_ACCESS_TOKEN, we might need to check the permission of running these workflow in setting as well.

@Lee-W Lee-W force-pushed the use-reusable-workflow-from-astronomer-providers-for-rc-testing branch 2 times, most recently from 6e55c2d to d3d04c7 Compare August 11, 2023 07:43
@Lee-W Lee-W force-pushed the use-reusable-workflow-from-astronomer-providers-for-rc-testing branch from d3d04c7 to c359f1b Compare August 11, 2023 08:29
@Lee-W Lee-W changed the title ci(github-actions): reuse reusable workflows for rc testing from astronomer-providers reuse reusable workflows for rc testing from astronomer-providers Aug 11, 2023
@Lee-W Lee-W marked this pull request as ready for review August 17, 2023 00:24
tatiana
tatiana approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Lee-W, thanks. This looks much cleaner!

Please let me know if you'd like help setting BOT_ACCESS_TOKEN to the repo, I can do this for you (just need you to send me the desired token)

@pankajastro pankajastro mentioned this pull request Aug 21, 2023
Open
@Lee-W Lee-W merged commit 0fe2054 into main Sep 7, 2023
2 checks passed
@Lee-W Lee-W deleted the use-reusable-workflow-from-astronomer-providers-for-rc-testing branch September 7, 2023 11:25
@Lee-W Lee-W mentioned this pull request Sep 7, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatiana tatiana tatiana approved these changes

@pankajastro pankajastro pankajastro approved these changes

@utkarsharma2 utkarsharma2 Awaiting requested review from utkarsharma2 utkarsharma2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lee-W @tatiana @pankajastro