Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use personal access token in rc workflow and extract it as a separate reusable workflow #1295

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Aug 11, 2023

  • extract check rc announcement as a reusable workflow
  • use BOT_ACCESS_TOKEN for test-rc-release
  • replace the fake account action@github.com with airflow-oss-bot@astronomer.io
  • rename Reusable workflows to separate them from other workflows
  • fix typo

@Lee-W Lee-W force-pushed the use-personal-access-token-in-rc-workflow branch 2 times, most recently from ceb811d to 9439f75 Compare August 11, 2023 04:09
@Lee-W
Copy link
Contributor Author

Lee-W commented Aug 11, 2023

圖片

@Lee-W Lee-W force-pushed the use-personal-access-token-in-rc-workflow branch from 9439f75 to a0bebd9 Compare August 11, 2023 04:22
@Lee-W Lee-W force-pushed the use-personal-access-token-in-rc-workflow branch from a0bebd9 to dd99df0 Compare August 11, 2023 04:50
@Lee-W Lee-W marked this pull request as ready for review August 11, 2023 04:50
@Lee-W Lee-W force-pushed the use-personal-access-token-in-rc-workflow branch 2 times, most recently from bc53f1e to 08930ba Compare August 11, 2023 08:19
@Lee-W Lee-W changed the title Use personal access token in rc workflow Use personal access token in rc workflow and extract it as a separte reusable workflow Aug 11, 2023
@Lee-W Lee-W changed the title Use personal access token in rc workflow and extract it as a separte reusable workflow Use personal access token in rc workflow and extract it as a separate reusable workflow Aug 11, 2023
@Lee-W Lee-W force-pushed the use-personal-access-token-in-rc-workflow branch from 9a91a61 to 76dd03b Compare August 17, 2023 00:28
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9bf9d73) 98.58% compared to head (b4c8aff) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          91       91           
  Lines        5446     5446           
=======================================
  Hits         5369     5369           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W merged commit ab1e851 into main Aug 17, 2023
11 checks passed
@Lee-W Lee-W deleted the use-personal-access-token-in-rc-workflow branch August 17, 2023 02:16
Lee-W added a commit to astronomer/astro-sdk that referenced this pull request Sep 7, 2023
)

# Description
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Reuse the workflow from
astronomer/astronomer-providers#1295 (Will need
to wait for its merge)

<!--
Issues are required for both bug fixes and features.
Reference it using one of the following:

closes: #ISSUE
related: #ISSUE
-->


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

nothing should be changed

## Does this introduce a breaking change?
no

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants