-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use personal access token in rc workflow and extract it as a separate reusable workflow #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lee-W
commented
Aug 11, 2023
•
edited
Loading
edited
- extract check rc announcement as a reusable workflow
- use BOT_ACCESS_TOKEN for test-rc-release
- replace the fake account action@github.com with airflow-oss-bot@astronomer.io
- rename Reusable workflows to separate them from other workflows
- fix typo
Lee-W
force-pushed
the
use-personal-access-token-in-rc-workflow
branch
2 times, most recently
from
August 11, 2023 04:09
ceb811d
to
9439f75
Compare
Lee-W
force-pushed
the
use-personal-access-token-in-rc-workflow
branch
from
August 11, 2023 04:22
9439f75
to
a0bebd9
Compare
2 tasks
Lee-W
force-pushed
the
use-personal-access-token-in-rc-workflow
branch
from
August 11, 2023 04:50
a0bebd9
to
dd99df0
Compare
Lee-W
requested review from
phanikumv,
pankajastro,
pankajkoti,
sunank200 and
utkarsharma2
as code owners
August 11, 2023 04:50
Lee-W
force-pushed
the
use-personal-access-token-in-rc-workflow
branch
2 times, most recently
from
August 11, 2023 08:19
bc53f1e
to
08930ba
Compare
Lee-W
changed the title
Use personal access token in rc workflow
Use personal access token in rc workflow and extract it as a separte reusable workflow
Aug 11, 2023
Lee-W
changed the title
Use personal access token in rc workflow and extract it as a separte reusable workflow
Use personal access token in rc workflow and extract it as a separate reusable workflow
Aug 11, 2023
pankajastro
approved these changes
Aug 16, 2023
…irflow-oss-bot@astronomer.io
Lee-W
force-pushed
the
use-personal-access-token-in-rc-workflow
branch
from
August 17, 2023 00:28
9a91a61
to
76dd03b
Compare
for more information, see https://pre-commit.ci
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 91 91
Lines 5446 5446
=======================================
Hits 5369 5369
Misses 77 77 ☔ View full report in Codecov by Sentry. |
Lee-W
added a commit
to astronomer/astro-sdk
that referenced
this pull request
Sep 7, 2023
) # Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Reuse the workflow from astronomer/astronomer-providers#1295 (Will need to wait for its merge) <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> nothing should be changed ## Does this introduce a breaking change? no ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.