Make the operator names consistent #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LoadFile` and `ExportFile` didn't have operator suffix. While it is not needed, I thought it would be good to make them consistent. This is a breaking change, thoughts?
kaxil
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 41 41
Lines 1670 1670
Branches 210 210
=======================================
Hits 1558 1558
Misses 89 89
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pankajkoti
approved these changes
Aug 12, 2022
kaxil
added a commit
that referenced
this pull request
Aug 18, 2022
`LoadFile` and `ExportFile` didn't have operator suffix. While it is not needed, I thought it would be good to make them consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadFileandExportFiledidn't have operator suffix. While it is not needed, I thought it would be good to make them consistent.