Add Redshift database support #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
pankajkoti
force-pushed
the
612-add-redshift-support
branch
from
2e5d376
to
e782e1f
Compare
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
This reverts commit b2649fe.
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
pankajastro
reviewed
Aug 24, 2022
pankajastro
reviewed
Aug 24, 2022
…mer/astro-sdk into 612-add-redshift-support
Squashing looks difficult as the branch has been rebased multiple times and also few conflicts have been handled with merge commits from main time to time. However, when the branch is merged to main it will appear as a single commit. |
sunank200
reviewed
Aug 25, 2022
There was a problem hiding this comment.
Overall great work with implementation of adding Redshift @pankajkoti . I have added few comments.
Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
sunank200
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
No support available for Redshift database
What is the new behavior?
Add support for Redshift database for the following operators:
Note: The
mergeoperator implementation needs some discussion and will beprovided in a subsequent PR.
Does this introduce a breaking change?
No.
Checklist
closes: #612