-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redshift database support #639
Conversation
for more information, see https://pre-commit.ci
2e5d376
to
e782e1f
Compare
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
This reverts commit b2649fe.
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
…mer/astro-sdk into 612-add-redshift-support
Squashing looks difficult as the branch has been rebased multiple times and also few conflicts have been handled with merge commits from main time to time. However, when the branch is merged to main it will appear as a single commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great work with implementation of adding Redshift @pankajkoti . I have added few comments.
Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
…mer/astro-sdk into 612-add-redshift-support
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just deepsource and CI has to run fine
Description
What is the current behavior?
No support available for Redshift database
What is the new behavior?
Add support for Redshift database for the following operators:
Note: The
merge
operator implementation needs some discussion and will beprovided in a subsequent PR.
Does this introduce a breaking change?
No.
Checklist
closes: #612